sillsdev / sillsdev/TheCombine
Domain search is too restrictive, shouldn't be accent/modifier-sensitive
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 22
- Forks
- 10
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 9
Description
It's not case sensitive, but it is accent sensitive (in Spanish, "limite" doesn't work for "Límite"--the accent is required over the i). For multi-word domain, the whole phrase is needed, so neither "universe" nor "creation" suffices to find "universe, creation"--neither "language" nor "thought" brings up "Language And Thought".
The search is primarily done by the numeric semantic domain id, so this isn't high priority.
Alternatively/Additionally, we may want to show suggestions as the user types.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the domain search entry point and reproduce the accent-sensitive and multi-word examples from the issue. Define done as allowing accent-insensitive and partial multi-word matching, or document a decided scope for typeahead suggestions, with tests covering the reported Spanish and phrase searches.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- search
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100