sillsdev / sillsdev/TheCombine
Remove vestigial `containerPort: 443` from the frontend Deployment
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 22
- Forks
- 10
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 9
Description
Composed by Devin:
The frontend container declares containerPort: 443 at deploy/helm/thecombine/charts/frontend/templates/deployment-frontend.yaml:69, but nothing inside the container listens on 443:
- nginx's active config listens only on 80 (
nginx/templates/default.conf.template:2). - TLS is terminated at the Kubernetes Ingress, not the frontend container (
docs/deploy/kubernetes_design/README.md:143-147). - The only
listen 443is innginx/templates/url_moved.conf:17-18, which lacks the.templatesuffix and isn't processed into an active server block.
containerPort is informational, so this is harmless dead config — a cleanup, not a bug.
Change: remove the - containerPort: 443 line at deploy/helm/thecombine/charts/frontend/templates/deployment-frontend.yaml:69.
Confirm first: no Service/Ingress targets the pod's 443, and nginx/templates/url_moved.conf isn't wired to an active 443 listener.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with deploy/helm/thecombine/charts/frontend/templates/deployment-frontend.yaml and inspect the Service and Ingress to confirm nothing targets pod port 443. Check nginx/templates/default.conf.template and nginx/templates/url_moved.conf as described. Done means removing the containerPort: 443 line and confirming the remaining active configuration uses port 80 with TLS handled by the Ingress.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- helm, kubernetes, nginx
- Domain
- devops, infrastructure
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 90/100