sillsdev / sillsdev/TheCombine

Update SemanticDomains-*.xml with trimmed English semantic domain descriptions

Open
#4,333 0 comments 0 reactions 1 assignee View on GitHub

@imnasnainaec is already working on this.

Since Jul 14, 2026.

Dominant language
TypeScript
Stars
22
Forks
10
Avg merge
2d 2h
Merged PRs (30d)
9

Description

Follow-up from sillsdev/FwLocalizations#5 ("Trim semantic domain descriptions") — see the task-list comment. That PR trimmed the English semantic domain descriptions in FwLocalizations lists/LocalizableLists.xml; this repo holds independent copies that need the same update.

A second follow-up, sillsdev/FwLocalizations#7 ("Fix semantic domain punctuation and spaces", merged), made 22 further punctuation/whitespace corrections to the same lists/LocalizableLists.xml — these need to be folded into the 12 SemanticDomains-*.xml files' embedded English text as well:

  • Missing terminal period added to Description text (8): Pain, Confession, Prosperity and Trouble, Countryside, Catch, Prevent, Symmetrical, Nicknames
  • Wrong terminal punctuation fixed (.?) (5): Old age Description (?.); Questions for Blood money, Majority, Encourage/Incite, and Nicknames (.?)
  • Stray trailing space before closing tag removed (7 Questions): Insanity, Body movement (forward/out), Situation/circumstances, Gnomic present, Strong (self-explanatory), Noun forms, Subordinator
  • Stray space before punctuation removed (2): head ExampleWords (fang , tusk), Sacred writings Description (religions .)

Full diff: https://github.com/sillsdev/FwLocalizations/pull/7/files

Task: update deploy/scripts/semantic_domains/xml/SemanticDomains-{ar,es,fr,hi,id,ml,my,pt,ru,sw,te,zh}.xml (12 language files).

Details from the comment:

  • There is no -en file — English lives inside each file as ws="en" runs.
  • SemanticDomains-fr.xml: The example words are from ×4, Add other domains… ×4 → stale.
  • These are static committed copies: database/Dockerfile does COPY semantic_domains/* /data/semantic-domains/; deploy/scripts/sem_dom_import.py converts XML→JSON at build. No generation from FwLocalizations.
  • Actively maintained — recent commit Purge sem dom examples (#4302) (2026-06-15), i.e. the same clean-up effort that sillsdev/FwLocalizations#5 references (#1456 / #4301).
  • Generator bridge: in FieldWorks Build/Localize.targets, the convertLocalizedListsToXliff / prepareSemanticDomainForCrowdin targets convert LocalizedLists-*.xml ↔ xliff, and PrepareSemanticDomainForTheCombine converts xliff → SemanticDomains-<locale>.xml — the generator behind TheCombine's committed copies.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.