sillsdev / sillsdev/TheCombine
[import] Fails with no-entry .lift file of format exported from The Combine
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 22
- Forks
- 10
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 9
Description
Possibly related to #4159
The handling of empty LIFT files isn't robust.
To Reproduce
Steps to reproduce the behavior:
- Export a project from The Combine
- Unzip the file
- Open the .lift file
- Delete all the entries
- Save the .lift file
- Zip the folder
- In The Combine, select the new zip for import
- See this non-descript error:
400 https://qa-kube.thecombine.app/v1/projects/nonempty/lift/uploadandgetwritingsystems
This case should probably be handled, even though we don't allow exporting empty projects. Our export may be missing something that a blank export from FieldWorks has and our importer expects.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the import using a zipped project whose .lift file has no entries, following the steps in the issue. Compare that file with a blank FieldWorks export and trace the import response at the reported uploadandgetwritingsystems endpoint; done means empty LIFT imports are handled without the 400 error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100