sillsdev / sillsdev/TheCombine
[MergeService] Use database to allow Transient instead of Singleton
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 22
- Forks
- 10
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 9
Description
#3725 changes services.AddTransient<IMergeService, MergeService>(); to services.AddSingleton<IMergeService, MergeService>(); in order to persist both a counter and a results dictionary for the duplicate finding. It would be good to move those thing to the database so that the MergeService can be Transient.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the MergeService registration changed in #3725 and trace how its counter and results dictionary support duplicate finding. Identify the database entry points used by this service; done means those values persist there while MergeService can be registered as Transient, with duplicate-finding behavior preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend, databases
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100