sillsdev / sillsdev/TheCombine
[ReviewEntries] Can save sense edits multiple times
Open
Nobody has claimed this yet.
bug
frontend
goal: ReviewEntries
lowpriority
Size: S
- Dominant language
- TypeScript
- Stars
- 22
- Forks
- 10
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 9
Description
Describe the bug
In Review Entries, in the Edit entry dialog, the save button can be clicked multiple times.
To Reproduce
- Go to Review Entries
- Click on the edit pencil icon at the start of one of the rows
- Scroll down to Pronunciations and add an audio recording (or several)
- Multi-click on the green check in the upper corner
- There was a
console.info(file);accidentally left in the code for debugging, but because of that, the console will show every time the save is attempted.
Expected behavior
The save/close buttons should be disabled while waiting for the save to complete.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the multi-click behavior in Review Entries using the Edit entry dialog, especially after adding an audio recording under Pronunciations. Find the save and close handling for that dialog; done means both buttons are disabled while the save is pending and repeated clicks no longer start additional saves.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100