sillsdev / sillsdev/TheCombine
In `Backend/Services/LiftService.cs`, "IN_PROGRESS" treated as a path
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 22
- Forks
- 10
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 9
Description
From code review :
"IN_PROGRESS" is not a path. One should not overload the contents of a variable - "special values" that change the meaning of the variable lead to bugs and make it hard to maintain. It is better to the dictionary value be a structure with
exportStatusandfilePathelements.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in Backend/Services/LiftService.cs and inspect the dictionary that currently uses "IN_PROGRESS" as a value. Trace the callers that consume those values, then separate exportStatus from filePath so the status is not represented as a path; done means callers no longer rely on the special value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100