sillsdev / sillsdev/TheCombine
Refactor AnnouncementBanner to not set its own position
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 22
- Forks
- 10
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 9
Description
The AnnouncementBanner component currently uses the current app URL to decide where it should be positioned on the screen. This is a job for the layout/page manager of the page on which it appears.
This will probably necessitate multiple "instances" of the AnnouncementBanner component so the banner state may need to be moved to a Redux state.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the AnnouncementBanner component and inspect how it uses the current app URL to choose its position and where its banner state is held. Review the page/layout manager and existing Redux patterns; done means positioning is delegated to the containing page and multiple banner instances can work correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100