signalapp / signalapp/Signal-iOS
Remove libwebp from decoding path
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 12.2k
- Forks
- 3.5k
- PR merge metrics
- No merged PRs in 30d
Description
- I have searched open and closed issues for duplicates
- I am submitting a bug report for existing functionality that does not work as intended
- This isn't a feature request or a discussion topic
Bug description
Signal for iOS still depends on libwebp. Since iOS 14, WebP decoding is natively supported [1], and the minimum deployment target for Signal for iOS is iOS 15. This makes the fallback in the function runLaunchTasksIfNeededAndReloadCaches obsolete. libwebp's decoder SDImageWebPCoder is no longer needed, as Apple's decoder SDImageAWebPCoder fully replaces it for all supported iOS versions.
[1] https://developer.apple.com/documentation/safari-release-notes/safari-14-release-notes (Safari 14 changes also apply to iOS 14)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read runLaunchTasksIfNeededAndReloadCaches and the references to SDImageWebPCoder and SDImageAWebPCoder; compare the supplied patch with the current decoder setup. Remove the obsolete fallback and libwebp decoder from the iOS decoding path, then verify that Apple's decoder remains used for the iOS 15 minimum target.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, swift
- Domain
- mobile
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 82/100