signalapp / signalapp/Signal-iOS

In `splash view`, the ToS component must have also the `link` accessibility trait for Voice Over

Open Beginner friendly
#6,309 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
12.2k
Forks
3.5k
PR merge metrics
No merged PRs in 30d

Description

  • I have searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

As a Voice Over user,
When I focus the button about terms of uses in the slash views,
Voice Over does not vocalize it as link even if it must because it opens an external web page

Steps to reproduce
  • Build the app from scratch
  • Enable Voice Over
  • Focus the ToS button

Actual result: ToS button is vocalized as button only

Expected result: ToS button must be vocalized also as link as it directs to another external page and not a view with the app as native view

Screenshots
Splash view with Voice Over Accessibility Inspector
Device info

Device: iPhone 17 Pro

iOS version: iOS 26.5

Signal version: build version from last main commit: 30da85beab750c23d691e8a91e2e6a96b0842080

Link to debug log

None

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the ToS control in the splash view with VoiceOver enabled, then locate the control's accessibility configuration. Confirm that it opens an external web page and should expose both button and link traits; done when VoiceOver announces it as both and the relevant iOS behavior is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
accessibility, mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.