signalapp / signalapp/Signal-iOS
Crash when attempting to link device
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 12.2k
- Forks
- 3.5k
- PR merge metrics
- No merged PRs in 30d
Description
- I have searched open and closed issues for duplicates
- I am submitting a bug report for existing functionality that does not work as intended
- This isn't a feature request or a discussion topic
Bug description
Describe here the issue that you are experiencing.
Steps to reproduce
I am experiencing this crash also:
- Get a iPhone (13)
- turn on lockdown mode
- Install Signal, open it
- say no on popups for: notifications, local network, contacts
- Get a mac (M1 MBP, 2021)
- turn on lockdown mode
- Install Signal
- Open Signal, get QR code
- Scan QR code from camera app on iPhone
- It opens Signal
- Signal says it needs a camera to link a device (even though you already deep linked into Signal)
- say no on popup for camera
- go to settings app to turn on camera
- scan qr code again, it opens signal app
- signal says it wants to scan qr code
- click to scan qr code from inside signal app
- say no to popup for microphone
Expected outcome:
- Camera access is not required for Signal to link a device (using a QR scanned by operating system and deep linking to Signal)
- If you do want to allow camera access, linking a device from inside the app should link the device
Actual outcome:
- Deep links do not work
- Unnecessary permissions are requested many times inside the app
- Crashes and linking devices is not possible
- iOS app crashes after step 17
Screenshots
Device info
Device:
- iPhone 13
- MacBook Pro 14-inch, 2021
iOS version:
- 16.7
- 14.0 (23A344)
Signal version:
The latest version on iOS app store as of 223-11-16.
Link to debug log
Email sent with subject: iOS Crash Log: GitHub issue #5705
And filename Signal-2023-11-16-184844.ips
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the emailed crash log Signal-2023-11-16-184844.ips and reproducing the numbered iPhone-to-Mac linking flow with the listed permissions and lockdown mode settings. Done means the iOS app does not crash, the deep link and in-app QR flow complete device linking, and the reported permission prompts behave as expected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100