signalapp / signalapp/Signal-iOS

Crash when attempting to link device

Open
#5,705 19 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Acknowledged
Dominant language
Swift
Stars
12.2k
Forks
3.5k
PR merge metrics
No merged PRs in 30d

Description

  • I have searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

Describe here the issue that you are experiencing.

Steps to reproduce

I am experiencing this crash also:

  1. Get a iPhone (13)
  2. turn on lockdown mode
  3. Install Signal, open it
  4. say no on popups for: notifications, local network, contacts
  5. Get a mac (M1 MBP, 2021)
  6. turn on lockdown mode
  7. Install Signal
  8. Open Signal, get QR code
  9. Scan QR code from camera app on iPhone
  10. It opens Signal
  11. Signal says it needs a camera to link a device (even though you already deep linked into Signal)
  12. say no on popup for camera
  13. go to settings app to turn on camera
  14. scan qr code again, it opens signal app
  15. signal says it wants to scan qr code
  16. click to scan qr code from inside signal app
  17. say no to popup for microphone

Expected outcome:

  1. Camera access is not required for Signal to link a device (using a QR scanned by operating system and deep linking to Signal)
  2. If you do want to allow camera access, linking a device from inside the app should link the device

Actual outcome:

  1. Deep links do not work
  2. Unnecessary permissions are requested many times inside the app
  3. Crashes and linking devices is not possible
  4. iOS app crashes after step 17
Screenshots
Device info

Device:

  1. iPhone 13
  2. MacBook Pro 14-inch, 2021

iOS version:

  1. 16.7
  2. 14.0 (23A344)

Signal version:

The latest version on iOS app store as of 223-11-16.

Link to debug log

Email sent with subject: iOS Crash Log: GitHub issue #5705

And filename Signal-2023-11-16-184844.ips

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the emailed crash log Signal-2023-11-16-184844.ips and reproducing the numbered iPhone-to-Mac linking flow with the listed permissions and lockdown mode settings. Done means the iOS app does not crash, the deep link and in-app QR flow complete device linking, and the reported permission prompts behave as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, swift
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.