signalapp / signalapp/Signal-iOS
Uncancelable donation
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 12.2k
- Forks
- 3.5k
- PR merge metrics
- No merged PRs in 30d
Description
- I have searched open and closed issues for duplicates
- I am submitting a bug report for existing functionality that does not work as intended
- This isn't a feature request or a discussion topic
Bug description
A donation no longer shows up on the Donate to Signal screen if a payment fails — however, the actual recurring payment isn't cancelled and will be made again on the following billing cycle, with no way to cancel it.
I'm now actually being charged twice for donations with no way to cancel. I had set up my original donation with a card which, at one point, had no funds for the payment to be made. Since the active donation no longer appeared on that screen, I went ahead and made a new donation, with a new card. However, on the next billing cycle, both my cards were charged.
I've emailed support but got no response (which is not a bug, but definitely not the best look for when the actual issue is about payments and money).
Steps to reproduce
- set up a donation
- let the payment fail on the recurring payment (for instance, make sure you don't have enough funds)
- check the active donation no longer shows up on the Donate to Signal screen
- make sure the payment method has enough funds for the next payment
Actual result: The card will be charged, even though the active donation doesn't appear on the app. There's no way to cancel that donation
Expected result: Card shouldn't be charged and/or I should still be able to cancel that donation.
Device info
Device: iPhone 11
iOS version: 16.5.1
Signal version: 6.34.0.10
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Donate to Signal screen and trace how recurring donations are represented after a payment failure. Reproduce the failed-payment flow using the listed iPhone and Signal version, then verify that the donation remains cancellable and is not charged unexpectedly on the next billing cycle.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile, payments
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100