signalapp / signalapp/Signal-iOS

Avatars slightly misaligned in contact pickers

Open
#5,451 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Acknowledged
Dominant language
Swift
Stars
12.2k
Forks
3.5k
PR merge metrics
No merged PRs in 30d

Description

  • I have searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

The avatars shown at the top of various pickers seem to be slightly lower than they should be. For example, in the viewer picker for private stories, in the picker for adding people to groups, etc.

Steps to reproduce
  1. Create a private story or edit an existing one > tap "Add Viewers".
  2. Select one or more users to add to the story.

Or:

  1. Go to the chat info / settings of a group.
  2. Press "Add Members".
  3. Select one or more users to add to the group.

Actual result: The avatars shown at the top are not vertically aligned with the background.

Expected result: The avatars shown at the top should be vertically aligned with the background.

Screenshots
Device info

Device: iPhone XR
iOS version: 16.1 Public Beta (20B5064c)
Signal version: 5.57.0.13

Link to debug log

https://debuglogs.org/ios/5.57.0/059a21eba4c0af7d93f40dd7a13c183be8dacc1040b8c501a9360ab5f7af8dc9.zip

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in the private-story viewer picker and the group Add Members picker on iOS, using the steps and screenshot in the report. Inspect the picker UI implementation and compare the selected avatars with their background; done means the avatars are vertically aligned in both picker flows.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.