signalapp / signalapp/Signal-iOS

Location Sharing Address Bug

Open
#5,208 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Acknowledged
Dominant language
Swift
Stars
12.2k
Forks
3.5k
PR merge metrics
No merged PRs in 30d

Description

  • I have searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

When attempting to share a location today using the option within signal, the first line of the address was not added to the link for Apple Maps causing a person I shared an address with to drive to the town center rather then the business I selected.

Steps to reproduce
  • Tap the '+' button in a chat.
  • Tap 'Location.'
  • Type in the search field 'Essmann's Cabinetry & Millwork' then tap on the address that appears below.
  • Tap the blue send arrow next to the name that appears on the map.

Actual result:
The first line of the address is not included in the Apple Maps link. When a user taps on the Apple Maps link they are directed to the Town of Germantown instead of Essmann's.

Expected result:
Apple Maps opens with directions to Essmann's.

Screenshots

screenshot

Device info

Device: iPhone 12 Pro

iOS version: 15.1.1

Signal version: 5.26.2.0

Link to debug log

https://debuglogs.org/8605852c9ce71d51674c5dc3c5864888373abc5f26ab0e64325e15252ff6b70d.zip

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Start by reproducing location sharing on iOS and trace how the selected address becomes an Apple Maps link; done when the complete address, including its first line, opens the intended destination.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.