signalapp / signalapp/Signal-iOS

[video call] no display rotation

Open
#4,239 15 comments 8 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Acknowledged
Dominant language
Swift
Stars
12.2k
Forks
3.5k
PR merge metrics
No merged PRs in 30d

Description

  • I have searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

During a video call, the screen will not rotate when turning the iPhone from portrait to landscape orientation.

Steps to reproduce
  • start a video call with someone (in portrait orientation)
  • turn the iPhone to landscape

Actual result: the video of your partner does not rotate correspondingly. Thus, your conversation partner is not displayed upright but 90° turned.

Expected result: the video of your partner should be rotated in correspondence with the orientation of the iPhone.

Note: interestingly, the tiny video of yourself that is taken by the front camera is rotated correctly.

Device info

Device: iPhone X, iPhone Air 2

iOS version: 12.4

Signal version: 2.41.0.21

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Start by reproducing a Signal video call on the listed iPhone and iOS versions, then trace the video-call orientation handling for the remote and local previews. Done means the remote video rotates correctly when switching between portrait and landscape without breaking the local preview.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
audio-video-rtc, mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.