signalapp / signalapp/Signal-Android

Sharing contact adds the wrong country code

Open
#9,677 17 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

acknowledged
Dominant language
Kotlin
Stars
29.4k
Forks
6.9k
PR merge metrics
No merged PRs in 30d

Description


Bug description

When sharing a contact using "Share" in Android Contacts, the contacts phone number gets altered and adds +1 in front of their phone number by Signal. This seems to happen if the contact does not have a country code added to their phone number.

Steps to reproduce
  • Go to your Android Contacts
  • Pick a contact without a country code in their phone number
  • Go to the More Options Menu (three dots)
  • Tap 'Share' and select a Signal Contact
  • Notice that the number has now changed format and a +1 has been added to the number.

Please note: This has been tested on Samsung S9 and a Nokia 7 as well, both up to date running the

Additionally, this bug may relate to #9439?

Actual result: The contacts number has been modified with a +1 in front. Causing the contact information to be invalid.
Expected result: The contact information should remain it's integrity when shared with Signal.

Screenshots

signal-attachment-2020-06-01-092314_002
signal-attachment-2020-06-01-092314_001

Device info

Device: Pixel 3A
Android version: 10
Signal version: 4.59.9

Link to debug log

N/A

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named in the report. First reproduce the Android Contacts > Share > Signal Contact flow with a number lacking a country code, then trace the sharing path and add coverage for preserving the original number rather than prepending +1.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.