signalapp / signalapp/Signal-Android
Sharing contact adds the wrong country code
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 29.4k
- Forks
- 6.9k
- PR merge metrics
- No merged PRs in 30d
Description
- I have searched open and closed issues for duplicates
- I am submitting a bug report for existing functionality that does not work as intended
- I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
- This isn't a feature request or a discussion topic
Bug description
When sharing a contact using "Share" in Android Contacts, the contacts phone number gets altered and adds +1 in front of their phone number by Signal. This seems to happen if the contact does not have a country code added to their phone number.
Steps to reproduce
- Go to your Android Contacts
- Pick a contact without a country code in their phone number
- Go to the More Options Menu (three dots)
- Tap 'Share' and select a Signal Contact
- Notice that the number has now changed format and a +1 has been added to the number.
Please note: This has been tested on Samsung S9 and a Nokia 7 as well, both up to date running the
Additionally, this bug may relate to #9439?
Actual result: The contacts number has been modified with a +1 in front. Causing the contact information to be invalid.
Expected result: The contact information should remain it's integrity when shared with Signal.
Screenshots


Device info
Device: Pixel 3A
Android version: 10
Signal version: 4.59.9
Link to debug log
N/A
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named in the report. First reproduce the Android Contacts > Share > Signal Contact flow with a number lacking a country code, then trace the sharing path and add coverage for preserving the original number rather than prepending +1.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100