signalapp / signalapp/Signal-Android

Adding attachments, intent handler does not show other sources in "Open from" window.

Open
#7,877 5 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

acknowledged
Dominant language
Kotlin
Stars
29.4k
Forks
6.9k
PR merge metrics
No merged PRs in 30d

Description


Bug description

When trying to add an attachment, after selecting the attachment type (Gallery, Audio, File, etc) the "Open from" intent handler will only show a reduced set of options "Recent" and "Downloads"

Steps to reproduce
  • Launch Signal
  • Open chat
  • Press attachment button (or 3dot menu > Add Attachment)
  • Press Gallery/Audio/File option
  • Slide from left (or open hamburger menu)

Actual result: "Open from" window displays Images/Videos/Recent/Downloads
Expected result: "Open from" window should display other installed applications capable of handling images

Screenshots

Actual:
screenshot_20180605-102654
Expected:
screenshot_20180605-102802

Device info

Device: OnePlus ONEPLUS A5000
Android version: 8.1.0
Signal version: 4.20.5

Link to debug log

https://debuglogs.org/6f1280815925815ae8cacd1e2e735a04e93bda49ca1348caac66cd54c9fcdab7
It doesn't appear to be captured in the logs but included anyways.

Notes

This issue has been highlighted previously but was part of the culling of stagnant issues.
https://github.com/signalapp/Signal-Android/issues/1744

A fix was proposed but never integrated, have been unable to contact user to have them sign the CLA
https://github.com/signalapp/Signal-Android/pull/3154

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the attachment flow from the chat's attachment button through Gallery, Audio, or File, then inspect the Android intent handler that opens the "Open from" window. Done means the window lists other installed applications capable of handling the selected attachment type, as shown in the expected result.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.