signalapp / signalapp/Signal-Android

Call popup window has incorrect width when flipping phone after opening a chat

Open
#13,658 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

acknowledged
Dominant language
Kotlin
Stars
29.4k
Forks
6.9k
PR merge metrics
No merged PRs in 30d

Description


Bug description

When I open a chat and change the phone's orientation, the size of the call popup is as if the phone wasn't rotated.

Steps to reproduce
  • Open an existing chat (portrait mode/widescreen)
  • Rotate your phone (portrait -> widescreen or widescreen -> portrait)
  • Click the call icon

Actual result: The popup has the width that the previous mode should have. That means that when I started with the portrait mode, I end up with a really tiny popup. When I start with the widescreen mode it even makes it impossible to initiate the call without flipping the phone again or exiting the chat.
Expected result: The popup width should be according to the current phone orientation. Not the orientation of the phone when opening the chat.

Screenshots

Screenshot_20240821_173013_Signal
Screenshot_20240821_172953_Signal

Device info

Device: Samsung SM-S908B/DS
Android version: 14
Signal version: 7.14.1

Note

This has also been a problem in a previous version on my google pixel 2 xl so I don't think it is a device problem. I'm sorry for the extra info you didn't ask for but I thought it could be helpful.

Link to debug log

Link to debug log

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the orientation-change sequence in Signal Android using the listed device context and debug log. The report names no files or tests, so trace the call popup from the chat screen and identify where its width is chosen after rotation. Done means the popup uses the current orientation when opened, with regression coverage if the relevant test location is found.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.