signalapp / signalapp/Signal-Android
The default should be alphanumeric instead of numeric
Open
Nobody has claimed this yet.
acknowledged
- Dominant language
- Kotlin
- Stars
- 29.4k
- Forks
- 6.9k
- PR merge metrics
- No merged PRs in 30d
Description
Hi, it seems like the default PinKeyboardType should be alphanumeric. If the PinKeyboardType gets a null value then it defaults to a numeric keyboard. The user can not ever confirm a pin that is alphanumeric.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with app/src/main/java/org/thoughtcrime/securesms/lock/v2/PinKeyboardType.java at the referenced line and inspect how a null PinKeyboardType is handled. Done means the null default is alphanumeric and users can confirm an alphanumeric PIN.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- authentication, mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100