signalapp / signalapp/Signal-Android
when disabeling backups, partial unfinished backup files should also be deleted
Open
Nobody has claimed this yet.
acknowledged
- Dominant language
- Kotlin
- Stars
- 29.4k
- Forks
- 6.9k
- PR merge metrics
- No merged PRs in 30d
Description
- I have searched open and closed issues for duplicates
- I am submitting a bug report for existing functionality that does not work as intended
- I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
- This isn't a feature request or a discussion topic
Bug description
Signal deleted backup files to prevent them from lingering onnyour device, however if you disable backups while creation of a new backup file is in progress, the .tmp file does not get deleted. This has three downsides:
- the file takes up unessesary space
- it may be a security risk if someone finds a copy of your old backup key and manages to het some information out of it
- it may confuse some users into thinking they have a backup file, not realizing it's a partial and will be useless when they need to preform a recovery
Device info
Device: Manufacturer Model XVI
Android version: 10.0.0
Signal version: 0.0.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points. Start by tracing backup creation and what happens when backups are disabled; done means an in-progress .tmp backup file is removed when backups are disabled, without leaving a partial recovery file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100