signalapp / signalapp/Signal-Android

Missing a warning dialog when saving media outside of Signal from the storage menu

Open
#11,345 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

acknowledged
Dominant language
Kotlin
Stars
29.4k
Forks
6.9k
PR merge metrics
No merged PRs in 30d

Description


Bug description

When you safe media from a conversation you get a warning pop-up /dialog/ screen/thingemajing about it not longer being encrypted if you proceed, with the options yes and no. However if you open the storage menu and start saving files from there, there isn't a single warning about the encryption no longer applying. It can not be assumed that a user who saves files this way will know that the encryption no longer applies. If the warning should not be shown every time, than at least one warning should be shown every once in a while if the user safes one or more files.

A security measure such as this encryption can only work if the user is making informed choices. Not warning the user is a significant weakness in this protection.

Device info

Device: Manufacturer Model XVI
Android version: 10.0
Signal version: 5.13.2

Link to debug log

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing media saving from the conversation and from the storage menu on Android, comparing the existing encryption warning with the storage-menu flow. Trace the storage-menu save entry point and determine where the warning should appear; done means users receive an informed-choice warning before media saved there loses Signal's encryption protection.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.