signalapp / signalapp/Signal-Android

bad code replacing

Open
#11,278 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

acknowledged
Dominant language
Kotlin
Stars
29.4k
Forks
6.9k
PR merge metrics
No merged PRs in 30d

Description

Google translate:
Hello,
I would like to point out to you a very very penalizing bug for all the inhabitants of the French overseas departments. Indeed, we use a rather particular telephone system, because although we are all in France, we each have our own international code.
France is +33
But Martinique for example (where I am) is +596.
However, our French telephone system replaces this international code with a national 0.
My number is recorded in signal in international format + 596696xxxxxx
And when I receive a call from mainland France, signal transforms the 0 into +596 (which is my own callsign) but which does not necessarily correspond to the number of the person who sent me this message. The sender's number is therefore FALSE. And if I try to answer him, I must have an error.
To achieve this, I have to send my message by replacing the +596 with a +33 manually.
You will agree that it is far from very practical.
Thank you in advance.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by reproducing the reported number transformation in Signal Android using a Martinique number receiving a call from mainland France, then trace where the sender number is normalized. Done means the sender retains the correct international identity and replies do not require manually replacing +596 with +33.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.