Already used animated stickers aren't fully animated on sticker selection widget

Open
#11,022 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
android, kotlin
Domain
mobile

Research direction

Reproduce the issue in the sticker selection widget using the listed steps and compare previously used stickers with stickers in the pack tab. Review the attached video and debug log while checking the widget's animation behavior across reopening, conversation changes, and screen locking; done means used animated stickers play fully and consistently.

Written by the indexing model from the issue text.

Description

acknowledged

Bug description

When opening the sticker selection widget, the first tab show the stickers previously used, If you have used animated stickers, only a few frames of these animations are show, less than a half a second. On the tab that shows the sticker packs, all not previously used stickers are fully animated, and again the used ones are partially animated and the are stuck as static. Long pressing over them shows the entire animation preview

Steps to reproduce
  • Send an animated sticker
  • Open another conversation
  • Open the sticker selection widget
  • Go to the sticker pack tab of the previously sent sticker
  • Go back to the previously used sticker tab.

Actual result: The first time the previously used stickers tab is shown the sticker is animated, when you go to the sticker pack tab, the animation of the used stickers are shown for a a small time and stops. Going back to the previously used stickers, the animation is partial too. Closing the sticker selection widget and reopening doesn't solve the issue, after reopen the used stickers play and stop always. If the conversation is closed and reopened, or open a new one, the bug restarts now the first time the previously used stickers are shown on the selection widget are fully animated.

Note: if the selection widget is open and stickers are stuck, locking with the power button and unlocking, bring the used sticker to life but skipping frames and sometimes accelerated. If animations are ok on the selection widget (immediately after opening it) , locking and unlocking doesn't break anything.

Expected result: Used animated stickers should be shown fully animated like all other stickers without problems.

Device info

Device: Pixel 4a (4G)
Android version: 11 (Android security update: February 5, 2021)
Signal version: 5.4.7

Video showing the issue

https://user-images.githubusercontent.com/1652983/112766049-0982a280-8fde-11eb-8198-fe7a9dc5a80b.mp4

Link to debug log

https://debuglogs.org/bf1b40b784085cf093344d2bf8b30ea2a34d921eb183539ddf9d23e986a6a797

Dominant language
Kotlin
Stars
29.4k
Forks
6.9k
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from signalapp/Signal-Android

All issues in signalapp/Signal-Android

Similar issues

More Kotlin issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.