sign / sign/pixel-renderer

Freeze Cairo and Pango Versions

Open
#2 8 comments 1 reaction 1 assignee View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2
Forks
3
PR merge metrics
No merged PRs in 30d

Description

It seems that the current repository does not specify exact versions of pango, cairo, manimpango and pygobject packages. Based on our previous experience with PIXEL-based models, working with different versions of these packages can significantly affect performance.

For instance, consider a model pretrained with cairo==1.16.x. If we switch to cairo==1.18.x during downstream task fine-tuning, the model’s performance could degrade substantially. There are two reasons for this issue:

  1. Different versions might produce slightly different visuals, which may be imperceptible to humans.
  2. PIXEL-based models currently process 16×16 patches using 16×16 convolutional filters. Thus, even the slightest change in patch visual can disrupt input processing in PIXEL-based models. This would be the case for WeLT if one follows the same design choices.

So, the action items would be,

  • Detect the versions of pango, cairo, manimpango and pygobject.
  • Check the rendering whether it works without any issues.
  • Fix the versions.

@AmitMY I can fix the versions if this is okay by you also as well.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.