siemens / siemens/gencmpclient

Fix and generalize the setting of the `recipient` field in subsequent messages of a transaction

Open
#9 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
15
Forks
13
Avg merge
7d 21h
Merged PRs (30d)
1

Description

According to the Lightweight CMP profile:

  recipient                   REQUIRED
    -- SHOULD be the name of the intended recipient; otherwise, the
    --   NULL-DN MUST be used
    -- In the first message of a PKI management operation: SHOULD be
    --   the subject DN of the CA the PKI management operation is
    --   requested from
    -- In all other messages: SHOULD contain the value of the sender
    --   field of the previous message in the same PKI management
    --   operation

So also the client should mirror whatever it received from the server.

When doing so (which is already done by the server side),
not only the directoryName choice of type X509_NAME, but any GENERAL_NAME should be supported.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the client-side construction of the recipient field in subsequent transaction messages and compare it with the server-side behavior mentioned in the issue. Inspect how OpenSSL GENERAL_NAME values are represented and passed through the client; done means subsequent messages mirror the previous sender and support every GENERAL_NAME choice, not only directoryName.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.