sidorares / sidorares/node-mysql2
Automatic Timezone Detection
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 4.4k
- Forks
- 680
- Avg merge
- 9h 7m
- Merged PRs (30d)
- 59
Description
Pending #732, as I mentioned here: https://github.com/sidorares/node-mysql2/pull/732#issuecomment-369091981
Once #732 lands, we then need to follow up with automatic detection of timezone incase the server is set to something different such as UTC.
Ideally, when the server timezone does not match the local client timezone, and the connection/pool config does not declare a specific desired timezone (set to 'local'),
then we should convert the timezone accurately.
I'm not sure If i'll personally be able to do this work, so leaving open for someone else to implement.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review pull request #732 first, since this issue is explicitly pending its changes. Then trace the connection and pool timezone configuration, focusing on the case where the setting remains 'local' and the server timezone differs from the client. Done means accurately converting times in that case without overriding an explicitly declared timezone.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mysql, node.js, typescript
- Domain
- backend, database
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100