sidorares / sidorares/node-mysql2
Rollback on transaction error
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 4.4k
- Forks
- 680
- Avg merge
- 9h 7m
- Merged PRs (30d)
- 59
Description
w.r.t #645 , how to rollback if any error occurs?
Also most of the time I am getting a deadlock and I have to restart my DB even when there are no errors.
Here is the sample transaction code:
const conn = null;
try {
conn = await pool.getConnection();
await conn.beginTransaction();
await conn.query('INSERT INTO ...', params);
await conn.commit();
conn.release();
} catch (e) {
// rollback here
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by reading issue #645 and tracing the transaction and connection-pool APIs used by the sample; reproduce the rollback and deadlock reports with a focused test or minimal case. Done means the expected rollback and connection-release behavior is established and the deadlock cause or a documented limitation is identified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, mysql, node.js
- Domain
- backend, database
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100