sidorares / sidorares/node-mysql2
Promise connection sync methods always proxy non-pool connection
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 4.4k
- Forks
- 680
- Avg merge
- 9h 7m
- Merged PRs (30d)
- 59
Description
This is an issue when using a PromiseConnection which wraps a PoolConnection. For example:
const {createPool} = require('mysql2/promise');
const pool = await createPool(options);
const connection = await pool.getConnection();
connection.destroy();
destroy only ever proxies Connection.prototype.destroy, not PoolConnection.prototype.destroy, so the connection isn't removed from the pool.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at promise.js line 258 and compare the proxied destroy method with PoolConnection.prototype.destroy. Reproduce the shown createPool/getConnection/destroy sequence and verify that destroying the connection removes it from the pool.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, mysql, node.js
- Domain
- database
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100