sidorares / sidorares/node-mysql2
notify all commands in the queue when connection is forcibly closed
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 4.4k
- Forks
- 680
- Avg merge
- 9h 7m
- Merged PRs (30d)
- 59
Description
I think here
We need to iterate connection queue first and call callback with error ( using Connection.prototype._notifyError )
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/pool_connection.js at the linked connection-close handling around lines 17-21. Read Connection.prototype._notifyError and inspect how the connection queue stores callbacks. Done means queued commands receive the closure error through their callbacks; verify the relevant queue behavior with the existing test suite.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mysql, node.js, typescript
- Domain
- backend, databases
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100