sidorares / sidorares/node-mysql2
Unit tests for Pools?
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 4.4k
- Forks
- 680
- Avg merge
- 9h 7m
- Merged PRs (30d)
- 59
Description
I've got a PR to add a connectionExpiry option to Pools that automatically terminates a connection after a set number of milliseconds. I went to write tests for it and realized that there aren't any tests at all for the pools.
Would it be worthwhile for me to try to port over the pool and pool cluster tests from node-mysql and update them for mysql2's changes?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the connectionExpiry PR mentioned in the issue and the pool and pool-cluster tests from node-mysql that are proposed for porting. Compare those tests with mysql2's pool implementation and changes, then confirm that equivalent coverage works for mysql2's pools and pool clusters.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mysql, nodejs, typescript
- Domain
- backend, database, testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100