sidorares / sidorares/node-mysql2
Wrong error returned without correcting sending internal Fatal error message
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- TypeScript
- Stars
- 4.4k
- Forks
- 680
- Avg merge
- 9h 7m
- Merged PRs (30d)
- 59
Description
To reproduce.. just pass null or undefined insted of sqlquery in execute method. The error returned by code is cant add new command when connection is closed.. I doubt if this error is returned the connection objects may be wrongly closed as well. Is it the case with others?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by calling the execute method with null or undefined instead of a SQL query. Trace the resulting "can't add new command when connection is closed" error and verify whether the connection object is actually closed; done means the internal Fatal error is corrected and the connection state is covered by a regression test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mysql, node.js, typescript
- Domain
- backend, database
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100