shopware / shopware/shopware

[Admin] Stabilize Admin Jest suite with Shopware.Feature.triggerDeprecationOrThrow included

Open
#20,450 0 comments 0 reactions 0 assignees View on GitHub
component/administration domain/framework
Dominant language
PHP
Stars
3.4k
Forks
1.2k
Avg merge
3d 55m
Merged PRs (30d)
436

Description

### Problem we must solve

When Shopware.Feature.triggerDeprecationOrThrow is introduced and added everywhere where a deprecation happens, the Jest suite will fail again for the major pipeline.

### WHY we need to solve it

Prepares the codebase for the next major to be more stable and more predictable

### Solution to the problem

Implement `Shopware.Feature.triggerDeprecationOrThrow`, migrate all places to use the helper function and fix all failed tests.

### WHO benefits

Internals who prepare very early for the major

### Accessibility

Backend-only work required

### WHERE will we do it

In admin

### Out of scope

_No response_

### Acceptance criteria

Jest suite runs in major mode with Shopware.Feature.triggerDeprecationOrThrow included

### Definition of Done

- [ ] Fulfills all acceptance criteria defined during discovery.
- [ ] Integration/E2E testing in staging is done.
- [ ] All integration/E2E/unit tests passing; all critical or high-priority bugs are resolved.
- [ ] Fulfills compliance, performance, security, and cloud-readiness needs.
- [ ] Observability—includes monitoring, alerting, and logging; incident response handbooks updated.
- [ ] Documentation—developer docs are written or updated, including information on how the feature or change is adopted and tested. If new functionality, end user documentation is written or updated.
- [ ] (conditional) All new API endpoints have a defined API schema.
- [ ] (conditional) If the change affects the Storefront, it has been tested in the latest three versions of Firefox, Chrome, Edge, IE11, and Safari, as well as the different viewports and devices (Desktop / Tablet / Mobile).
- [ ] (conditional) If the change affects the Administration, it has been tested in current versions of Firefox, Chrome, and Edge.
- [ ] (conditional) Functionality that includes new API routes are callable via the Store-API (/store-api/[version]/).
- [ ] (conditional) If a new Admin module is created, the access control layer is provided, and permissions can be managed via the Users & Permissions module.
- [ ] (conditional) If a new UI input field or interactive element is introduced, the ACL wrapper is added.
- [ ] (conditional) Performance testing done if the change has a high performance impact, such as affecting scalability, load balancing, or query optimization.

Contributor guide

Open the contributing guide

Research direction

Start in the Administration codebase by locating Shopware.Feature.triggerDeprecationOrThrow and the existing deprecation call sites. Run the Admin Jest suite in major mode to identify failures, then verify that all deprecation sites use the helper and that the suite passes in major mode.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.