shipshapecode / shipshapecode/shepherd

Pinch zooming gestures breaking overlay on Android (Brave) and iPad (Safari)

Open
#2,495 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
13.8k
Forks
658
Avg merge
4d 5h
Merged PRs (30d)
15

Description

Version: 11.2.0
Devices: iPad (iOs safari), Android (on Brave)

Pinch zooming on touch devices are causing problems with the overlay, where
the overlay rectangle stays locked to the top left of the layout viewport (this is the main problem), and is the size of the visualviewport (this is fine).
But because the overlay is not moving, part of the document does not have the overlay, which allows you to interact with this part of the document (despite it disallowing pinch and pan gestures), plus the overlay looks weird.

on desktop devices, when you change the zoom level (by doing ctrl+scrolling) the overlay seems to fix itself, but this process does not seem to happen on these touch devices.

This happens on https://shepherdjs.dev/ as well.

On a Chromebook, pinch zooming seemingly works correctly.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue on the Shepherd demo using iPad Safari and Android Brave, then trace the overlay's handling of pinch zooming and visual-viewport changes. Done means the overlay remains aligned with the document and continues preventing interaction outside it after touch-device zooming, while preserving the behavior that already works on Chromebook and desktop.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.