shift-org / shift-org/shift-docs

prettify the "all events feed" banner

Open
#802 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement frontend
Dominant language
JavaScript
Stars
30
Forks
25
Avg merge
9m
Merged PRs (30d)
1

Description

as per this from @carrythebanner re: the new all events feed.

https://github.com/shift-org/shift-docs/pull/797#pullrequestreview-2273284480

Could also add the cal feed banner to the /calgrid page, and could probably hide it on individual ride listings...
With 2 promo banners stacked there's a bit much in terms of top matter, but we'll be hiding the PP promo banner in 2 days so that's a non-issue IMO.

the feed info is hidden from single events:
image

but we could add it to the calgrid, and we should figure out how to make it play nicer with the pedalp banner.

( some possible ideas: maybe move it to the bottom, merge it with the "safe for all" section, maybe add info about the bikefun app? )

image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the existing all-events feed banner on the individual ride listings with the /calgrid page, using the linked review and screenshots as context. Decide how the feed information should coexist with the Pedalpal banner, then verify that the chosen arrangement is appropriate on both page types and that the banner is hidden from single events.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
design, frontend, web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.