shift-org / shift-org/shift-docs

[node] consider a graceful failure in case of npm package snafu

Open
#683 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

backend question
Dominant language
JavaScript
Stars
30
Forks
25
Avg merge
9m
Merged PRs (30d)
1

Description

It seems like at present if something went wrong during npm install, the site would be broken until we reverted/cleaned up the problem (since it tears down the old install before starting the now-broken one and thus it fails in a broken state).

We should make this more resilient / smarter (e.g. work in a copy of the image to ensure it builds and then swap the copy in?)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file, test, or deployment entry point is named in the issue. First locate the npm install and site replacement flow, then determine how a failed install can leave the previous working site available; done means an npm failure does not leave the site broken and the failure can be recovered or reported clearly.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
devops, infrastructure
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.