shift-org / shift-org/shift-docs

Remove hide and print flag fields from events endpoint

Open
#576 3 comments 0 reactions 1 assignee View on GitHub

@carrythebanner is already working on this.

Since Jan 30, 2024.

API backend frontend
Dominant language
JavaScript
Stars
30
Forks
25
Avg merge
9m
Merged PRs (30d)
1

Description

From #555 — see description in comment at https://github.com/shift-org/shift-docs/issues/555#issuecomment-1892683221.

These fields aren't needed in the public read-only events endpoint:

  • hideemail
  • hidephone
  • hidecontact
  • printemail
  • printphone
  • printweburl
  • printcontact

They should still be accepted and sent in the manage_event and retrieve_event endpoints.

Also, we should keep the print title and print description fields in the events endpoint response, at least for now. We currently use those in the calendar grid view and the iCal feed. We may revisit that eventually, but their current usage is different than these boolean flag fields.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.