shift-org / shift-org/shift-docs

Seconds value unneeded for start/end time fields in events API

Open
#554 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

API backend enhancement
Dominant language
JavaScript
Stars
30
Forks
25
Avg merge
9m
Merged PRs (30d)
1

Description

The events API currently outputs time (start time) and endtime values as HH:MM:SS. When creating an event you can only specify HH:MM, so seconds are useless precision that are always zero.

Check that the front-end and ICS calendar feed generation still parse HH:MM correctly (and anything else that uses EventTime->toEventSummaryArray()).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at EventTime->toEventSummaryArray(), then trace the events API output and the front-end and ICS calendar feed consumers mentioned in the issue. Check that start and end times use HH:MM and that all affected consumers still parse the shortened values correctly; done means the API no longer emits unnecessary seconds without breaking those consumers.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api, frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.