shift-org / shift-org/shift-docs

Improve handling of image files with no extension

Open
#540 0 comments 0 reactions 1 assignee View on GitHub

@carrythebanner is already working on this.

Since Sep 26, 2023.

backend enhancement frontend
Dominant language
JavaScript
Stars
30
Forks
25
Avg merge
9m
Merged PRs (30d)
1

Description

The vast majority of image files that people upload have an extension. However, image files which lack an extension but are otherwise valid are still accepted by the Add Event form. (See discussion on PR #527.) This may lead to some minor bugs, so we should test it out and consider smoothing out the edges if/when we find wrinkles. We could consider disallowing them, but more likely we may just want to check how the files are passed around and check any assumptions that it will always have an extension.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.