shift-org / shift-org/shift-docs

previewing an event doesn't show an image

Open
#528 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
30
Forks
25
Avg merge
9m
Merged PRs (30d)
1

Description

when you click the preview button, the image shown is always a placeholder.

it seems that the lazy loading doesn't play well with preview -- i think because preview is maybe rendering html in place, and not triggering a new load event. [ i think this also leads to the behavior where if you press browser "back" from preview, you wind up at the calendar page, not your edit event page because previewing doesnt change the url or alter history ]

image

note: that the edit page itself doesn't update its image when an image is selected; so it'd be nice -- if it were possible -- to have a solution which showed the new image -- pre-upload -- for both the edit and preview modes.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the preview button and trace how the event image is rendered and lazy-loaded in both preview and the edit-event page. Reproduce the placeholder-image behavior with a newly selected image, then verify that the selected image appears before upload in both modes and that preview navigation behaves as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.