shift-org / shift-org/shift-docs

Clean up print title & description validations

Open
#503 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
30
Forks
25
Avg merge
9m
Merged PRs (30d)
1

Description

Splitting off from #417:

in manage_event.php there's also this form validator that's currently commented out

// required only from March to June, during Pedalpalooza
     // $validator->addRequiredFields('tinytitle', 'printdescr');

That bit has been commented out for a while (since #295). There are broader questions about what to do with the print title/description fields (they're currently used in some non-print contexts, and we don't have a print calendar every year), but we should at least clean up this code to reflect reality.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open manage_event.php and inspect the commented-out tinytitle and printdescr validator. Confirm the current title and description validation paths before removing the obsolete commented code, while leaving the broader print-field behavior unchanged. Done means the stale validator reference is gone and existing non-print uses still work.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.