shift-org / shift-org/shift-docs
Add/edit form - error styles persist on the terms checkboxes even after correcting the errors
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 30
- Forks
- 25
- Avg merge
- 9m
- Merged PRs (30d)
- 1
Description
- Go to the add/edit form
- Choose a date, but leave all other required fields blank
- Submit the form; see that error styles have been applied to required fields
- Check the "code of conduct" and "ride comic" checkboxes, leaving the other required fields blank still
- Submit the form again
Result
The <input> elements correctly changed to aria-invalid="false", but the checkbox labels are still styled in red.
Expected result
The <input> elements correctly changed to aria-invalid="false", and the checkbox labels have reverted their default, non-error state.
Note
See /site/themes/s2b_hugo_theme/static/js/cal/addevent.js#L186 and #L129. The has-error class is being assigned and removed with actions that aren't symmetrical.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with site/themes/s2b_hugo_theme/static/js/cal/addevent.js, especially lines 129 and 186, and reproduce the add/edit form steps described in the issue. Compare how the has-error class is assigned and removed for the checkbox labels. Done means the labels return to their default, non-error styling after the checkboxes are corrected and the form is submitted again.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100