shift-org / shift-org/shift-docs
calendar: Make calendar secrets work if they contain hyphens
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 30
- Forks
- 25
- Avg merge
- 9m
- Merged PRs (30d)
- 1
Description
Our auto-generated secret links are random letters and numbers only. But sometimes when we create an edit link for someone by hand, it's useful to have a more readable link like https://shift2bikes.org/addevent/edit-99999-not-very-secret. Right now, if the secret contains a hyphen as in not-very-secret only the portion before the first hyphen will be interpreted as the secret (not). The result is that the link can't actually be used to manage the event, because the event can't be updated without the correct secret.
We can just stop including hyphens in secrets as a short-term solution, but longer term it would be nice to handle those.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the calendar edit-link entry point /addevent/edit-... and trace how the secret is parsed. Reproduce the failure with not-very-secret, then verify that the complete hyphenated secret is accepted and the event can be updated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100