Windows update octobor 2019 breaks execSync if destination folder is for a user with space in name
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 14.4k
- Forks
- 756
- PR merge metrics
- No merged PRs in 30d
Description
Node version (or tell us if you're using electron or some other framework):
8.10.0
ShellJS version (the most recent version/Github branch you see the bug on):
0.5.3
Operating system:
Windows 10
Description of the bug:
Problem arises after a windows update in october 2019. Before the update when user had a space in username, the temp file created created a new folder with "%20" instead of the space in "C:\Users". After the update the command execSync is not able to run the command if the user has a space in username.
Example ShellJS command to reproduce the error:
"C:\Program Files\nodejs\node.exe" C:\Users\FirstName LastName\AppData\Local\Temp\shelljs_clsjdbfljsbdfldf456456
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing execSync on Windows 10 with Node 8.10.0 and a username containing a space, using the temporary path shown in the issue. Trace how the command and destination path are formed in ShellJS 0.5.3. Done means the displayed node command executes successfully for such user paths without the %20 or space-related failure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, nodejs
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100