shell-pool / shell-pool/shpool

Bug on Kitty: Terminfo file not found

Open
#59 9 comments 1 reaction 1 assignee View on GitHub

@ethanpailes is already working on this.

Since Jun 21, 2024.

bug
Dominant language
Rust
Stars
2k
Forks
67
Avg merge
3d 1h
Merged PRs (30d)
15

Description

What happened
I can't create shpool sessions in kitty-terminal but I can with gnome-terminal.
Here's the output that appears in journalctl -f:

ThreadId(07) handling new connection: resolving terminfo
REDACTED shpool[2274258]: Caused by:
REDACTED shpool[2274258]:     Terminfo file not found

Here are relevant outputs in my kitty:

❯ echo $TERMINFO
/home/$USER/.local/kitty.app/lib/kitty/terminfo
❯ echo $TERM
xterm-kitty

And on gnome-terminal:

[11:51]echo $TERMINFO
/home/USER/.local/kitty.app/lib/kitty/terminfo
[11:51]>echo $TERM
xterm-256color

So I tried this in kitty: TERM="xterm-256color" shpool attach -f "test" and it worked directly.

What I expected to happen
First, this error should appear not only in journalctl but to the user that called it! I get no feedback that shpool failed except that shpool list shows an empty list.
Then, the error is incorrect: it should not be "Terminfo" file not found (the file is found) but has to do with $TERM.

To Reproduce
Steps to reproduce the behavior:

  1. Run `journalctl -f | grep shpool
  2. In gnome-terminal (=a working shpool terminal) run TERM="xterm-kitty" shpool attach -f "test"
  3. Notice the absence of error in the shell
  4. Notice the error in the journal

Version info
shpool 0.6.2

Logs

shpool[2274258]: INFO ThreadId(01) run:serve: socket got a new connection
shpool[2274258]: INFO ThreadId(33) handle_conn{cid=14}: new
shpool[2274258]: INFO ThreadId(33) handle_conn{cid=14}:parse_connect_header: new
shpool[2274258]: INFO ThreadId(33) handle_conn{cid=14}:parse_connect_header: close time.busy=88.6µs time.idle=12.6µs
shpool[2274258]: INFO ThreadId(33) handle_conn{cid=14}:handle_attach: new
shpool[2274258]: INFO ThreadId(33) handle_conn{cid=14}:handle_attach: locked shells table
shpool[2274258]: INFO ThreadId(33) handle_conn{cid=14}:handle_attach: no existing 'test' session, creating new one
shpool[2274258]: INFO ThreadId(33) handle_conn{cid=14}:handle_attach: creating new subshell
shpool[2274258]: INFO ThreadId(33) handle_conn{cid=14}:handle_attach:spawn_subshell: new
shpool[2274258]: INFO ThreadId(33) handle_conn{cid=14}:handle_attach:spawn_subshell: user_info=Info { default_shell: "/bin/zsh", home_dir: "/home/USER", user: "USER" }
shpool[2274258]: INFO ThreadId(33) handle_conn{cid=14}:handle_attach:spawn_subshell:inject_env: new
shpool[2274258]: INFO ThreadId(33) handle_conn{cid=14}:handle_attach:spawn_subshell:inject_env: injecting TERM into shell Some("xterm-kitty")
shpool[2274258]: INFO ThreadId(33) handle_conn{cid=14}:handle_attach:spawn_subshell:inject_env: close time.busy=40.3µs time.idle=6.14µs
shpool[2274258]: INFO ThreadId(33) handle_conn{cid=14}:handle_attach:spawn_subshell: close time.busy=194µs time.idle=5.47µs
shpool[2274258]: INFO ThreadId(33) handle_conn{cid=14}:handle_attach: close time.busy=248µs time.idle=8.34µs
shpool[2274258]: INFO ThreadId(33) handle_conn{cid=14}: close time.busy=433µs time.idle=24.7µs
shpool[2274258]: ERROR ThreadId(33) handling new connection: resolving terminfo
shpool[2274258]: Caused by:
shpool[2274258]:     Terminfo file not found

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.