shell-pool / shell-pool/shpool

shpool process hanging on ssh credentials timeout

Open
#155 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
2k
Forks
67
Avg merge
3d 1h
Merged PRs (30d)
15

Description

Both with mosh & ssh + shpool, I've been finding shpool process hanging. If the shpool process is directly killed, then detach + list work fine, but if I try an shpool list with the process live, the daemon hangs and a systemctl --user restart shpool is need -- aka, everything getting killed.

It appears connected with ssh credentials timing out; refreshing the credentials doesn't seem to solve the problem.

What I find in the logs is:

2024-09-25T08:27:57.783362Z ERROR ThreadId(274) handling new connection: writing version header
Caused by:
0: serializing data
1: invalid value write: error while writing multi-byte MessagePack value
2: error while writing multi-byte MessagePack value
3: Broken pipe (os error 32)

shpool version 0.7.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the hang with shpool over both mosh and ssh while credentials time out, then inspect the daemon logs for the version-header and MessagePack errors shown here. Done means a live daemon no longer hangs during shpool list, and detach, list, and systemctl --user restart shpool remain usable without killing the process.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.