shell-pool / shell-pool/shpool-vterm
we may not handle scroll region properly when scrolling up
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1
- Forks
- 1
- Avg merge
- 18h 49m
- Merged PRs (30d)
- 4
Description
I had to do a bunch of scroll region related stuff in the scroll down handler in https://github.com/shell-pool/shpool-vterm/commit/68374289d09ff56231b3c363707eec6970aa3316 and I think we may need to do something simillar for scroll_up
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the scroll-down changes in commit 68374289d09ff56231b3c363707eec6970aa3316, then inspect the corresponding scroll_up handler and its scroll-region handling. Compare the two paths and verify that scrolling up preserves the expected scroll region behavior; the issue is done when the up path handles the same relevant cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100