share / share/sharedb

Remove `db.getCommittedOpVersion`

Open
#402 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

breaking-change
Dominant language
JavaScript
Stars
6.5k
Forks
456
Avg merge
1d 5h
Merged PRs (30d)
5

Description

sharedb-mongo maintains an index against all ops to handle a corner case where we may submit a create op twice: https://github.com/share/sharedb-mongo/issues/94

It would be nice to remove the need for this index, and therefore we'd need to remove the method that relies on it: db.getCommittedOpVersion, which is only used in this one place.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked sharedb-mongo issue about duplicate create operations, then locate the sole use of db.getCommittedOpVersion and the index it depends on. Trace how that corner case is handled and confirm the method and index can be removed without regressing duplicate-op behavior; the issue is done when those dependencies are no longer needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend, database
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.