share / share/sharedb

Examples not working in Windows - `npm run build` fails

Open
#103 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
6.5k
Forks
456
Avg merge
1d 5h
Merged PRs (30d)
5

Description

Leaderboard:

C:\Users\alallier\Documents\sharedb\examples\counter>npm run build

> counters@0.0.1 build C:\Users\alallier\Documents\sharedb\examples\counter
> mkdir -p dist/ && ./node_modules/.bin/browserify client.js -o dist/bundle.js

The syntax of the command is incorrect.

Counter:

C:\Users\alallier\Documents\sharedb\examples\counter>npm run build

> counters@0.0.1 build C:\Users\alallier\Documents\sharedb\examples\counter
> mkdir -p dist/ && ./node_modules/.bin/browserify client.js -o dist/bundle.js

The syntax of the command is incorrect.

Even when removing the -p of mkdir in the build script this still fails

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the build scripts used by the Leaderboard and Counter examples and reproduce npm run build on Windows. Inspect the mkdir -p dist/ and Browserify command around client.js; done means both examples build successfully on Windows and produce their expected dist/bundle.js output.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.