share / share/sharedb-mongo

ShareDB CI Breakage

Open
#147 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
152
Forks
68
Avg merge
1d 5h
Merged PRs (30d)
3

Description

The ShareDB CI pipeline seems impacted by recent changes here, as evidenced by this PR:

https://github.com/share/sharedb/pull/599

The output there reads:

Run scripts/test-sharedb-mongo.sh
Cloning into 'sharedb-mongo'...
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: sharedb-mongo@3.0.1
npm ERR! Found: sharedb@3.2.[4](https://github.com/share/sharedb/actions/runs/4323100701/jobs/7546300118#step:9:5)
npm ERR! node_modules/sharedb
npm ERR!   sharedb@"file:../sharedb" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer sharedb@"^1.0.0-beta || ^2.0.0" from sharedb-mingo-memory@1.2.0
npm ERR! node_modules/sharedb-mingo-memory
npm ERR!   dev sharedb-mingo-memory@"^1.1.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /home/runner/.npm/eresolve-report.txt for a full report.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2023-03-03T11_47_[5](https://github.com/share/sharedb/actions/runs/4323100701/jobs/7546300118#step:9:6)8_0[7](https://github.com/share/sharedb/actions/runs/4323100701/jobs/7546300118#step:9:8)2Z-debug-0.log

It looks like to do with

Proposed fix

I would guess that upgrading the sharedb-mingo-memory version here would solve the issue.

Also, for the sake of stability, it may be worth having ShareDB's scripts/test-sharedb-mongo.sh use a specific commit of this repository, as currently the CI of ShareDB is vulnerable to changes in this repo because that script always pulls the latest from here.

Cheers!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the sharedb-mongo dependency on sharedb-mingo-memory and the peer dependency entry in sharedb-mingo-memory/package.json. Run scripts/test-sharedb-mongo.sh and review PR 599 to confirm the dependency-resolution failure. Done means the ShareDB CI script completes successfully with compatible dependency versions; assess separately whether pinning the repository commit is in scope.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, mongodb, node.js
Domain
ci-cd, database
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.