Ensure selecting of assets within grouped asset lists work without issue

Open
#11,631 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
react, typescript
Domain
frontend, web-dev

Research direction

Start by reproducing the issue in the trade modal with a connected wallet holding balances for the same asset across multiple chains, then inspect the grouped asset drawer's scroll and selection behavior. Done means scrolling to the bottom of a long list no longer closes the drawer and a chain can be selected.

Written by the indexing model from the issue text.

Description

bug polish

Context [Author]

grouped assets drawer closes when scrolling down during asset selection making it hard to select an asset at the bottom of the drawer. https://jam.dev/c/2a05fdb6-d188-4db8-a67a-9f953c8f5610

Does seem to work with out issues with no wallet connected, also in wallets without balances across chains.

Reproduction [Author]

connect wallet, go to trade modal, select an asset with a large number of chains supported that wallet has a balance of on multiple chains (ex. USDC) , try to scroll to bottom of long list

Screenshots, video [Author]

https://jam.dev/c/2a05fdb6-d188-4db8-a67a-9f953c8f5610

AC
Should be able to scroll to bottom of long asset list to select a chain that doesn't have supported asset

Rough how to fix [Eng]

Breakdown a path to solve for acc or any reference material, docs. A place for estimation notes or initial comments for solutions.

Dominant language
TypeScript
Stars
204
Forks
199
Avg merge
8h 1m
Merged PRs (30d)
64

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from shapeshift/web

All issues in shapeshift/web

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.